Skip to content

Add load.bash helper for standardized includes#54

Open
jacksgt wants to merge 1 commit intobats-core:masterfrom
jacksgt:jack-add-loader
Open

Add load.bash helper for standardized includes#54
jacksgt wants to merge 1 commit intobats-core:masterfrom
jacksgt:jack-add-loader

Conversation

@jacksgt
Copy link

@jacksgt jacksgt commented May 14, 2025

This makes it easier to include the library with bats_load_library:

bats_load_library has two modes of resolving requests:
by relative path from the BATS_LIB_PATH to a file in the library
by library name, expecting libraries to have a load.bash entrypoint

https://bats-core.readthedocs.io/en/stable/writing-tests.html#bats-load-library-load-system-wide-libraries

Closes #52

@vincent-zurczak
Copy link
Member

vincent-zurczak commented May 15, 2025

Hello!
Thank you for this contribution. There is another PR to fix the CI.
In the meantime, could you amend your commit and sign it please? It seems that we will not be able to merge your commit until it is signed.

@vincent-zurczak
Copy link
Member

vincent-zurczak commented May 15, 2025

@jacksgt Can you rebase your branch from master please?
We updated the CI process.

@jacksgt
Add load.bash helper for standardized includes
cf7ca2c 
This makes it easier to include the library with bats_load_library:

> bats_load_library has two modes of resolving requests:
> by relative path from the BATS_LIB_PATH to a file in the library
> by library name, expecting libraries to have a load.bash entrypoint

https://bats-core.readthedocs.io/en/stable/writing-tests.html#bats-load-library-load-system-wide-libraries

Signed-off-by: Jack Henschel <jackdev@mailbox.org>
@jacksgt jacksgt force-pushed the jack-add-loader branch from 0586236 to cf7ca2c Compare May 15, 2025 18:11
@jacksgt
Copy link
Author

jacksgt commented May 15, 2025

@vincent-zurczak Done and done! Thanks for taking a look :-)

@vincent-zurczak
Copy link
Member

vincent-zurczak commented May 17, 2025

Hello @jacksgt.
Github keeps on saying we cannot merge because « Commits must have verified signatures ».

Could you amend your commit once again and sign it please?
As a reminder, here is how to sign commits: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@vincent-zurczak
Copy link
Member

vincent-zurczak commented Jul 10, 2025

Hello @jacksgt.
Any news about the signed commit? I know this is not convenient.

@brokenpip3
Copy link
Contributor

brokenpip3 commented Mar 15, 2026

@jacksgt do you have any news? otherwise we can force-push a co-signed commit but I want to avoid that.
Thanks and sorry for annoyance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincent-zurczak vincent-zurczak vincent-zurczak approved these changes

@brokenpip3 brokenpip3 brokenpip3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add load.bash helper file

3 participants

@jacksgt @vincent-zurczak @brokenpip3